PWX-32825: Adjusting version triggers for px-3.0.1 #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1207 +/- ##
=======================================
Coverage 75.77% 75.77%
=======================================
Files 65 65
Lines 18410 18410
=======================================
Hits 13951 13951
Misses 3464 3464
Partials 995 995
☔ View full report in Codecov by Sentry. |
|
Travis failing due to unrelated error -- Will rebase + retest |
zoxpx
force-pushed
the
PWX-32825_adjusting_version_triggers
branch
from
a2ee82b
to
cb71ce2
Compare
harsh-px
approved these changes
Aug 17, 2023
|
Change looks good. But we need to resolve conflicts before merge. |
Signed-off-by: Zoran Rajic <zox@portworx.com>
zoxpx
force-pushed
the
PWX-32825_adjusting_version_triggers
branch
from
cb71ce2
to
a08d013
Compare
|
Thanks for the review Harsh -- merging this PR, will cherry-pick into |
zoxpx
added a commit
that referenced
this pull request
Aug 17, 2023
Signed-off-by: Zoran Rajic <zox@portworx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ISSUE:
3.0.1-ubuntu1604-- and this BROKE the version-checks3.0.1-ubuntu1604), will evaluate similar like3.0.1.1(a version higher than3.0.1)FIX:
version.GreaterThanOrEqual("3.0.1")intoversion.GreaterThan("3.0")Which issue(s) this PR fixes (optional)
Closes # PWX-32825
Special notes for your reviewer: